Skip to content

Commit af34e98

Browse files
committed
test: make rpc_psbt.py usable with --usecli
The psbt string would include a "=" sign, which would make the cli interpret this as a named argument. Fix this by making it an actual named arg with the correct name.
1 parent 8f8ce9e commit af34e98

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

test/functional/rpc_psbt.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,6 @@ def set_test_params(self):
7272
# whitelist peers to speed up tx relay / mempool sync
7373
for args in self.extra_args:
7474
args.append("[email protected]")
75-
self.supports_cli = False
7675

7776
def skip_test_if_missing_module(self):
7877
self.skip_if_no_wallet()
@@ -96,7 +95,7 @@ def test_psbt_incomplete_after_invalid_modification(self):
9695
signed_psbt_obj.g.map[PSBT_GLOBAL_UNSIGNED_TX] = bytes.fromhex(raw)
9796

9897
# Check that the walletprocesspsbt call succeeds but also recognizes that the transaction is not complete
99-
signed_psbt_incomplete = wallet.walletprocesspsbt(signed_psbt_obj.to_base64(), finalize=False)
98+
signed_psbt_incomplete = wallet.walletprocesspsbt(psbt=signed_psbt_obj.to_base64(), finalize=False)
10099
assert signed_psbt_incomplete["complete"] is False
101100

102101
def test_utxo_conversion(self):
@@ -1209,7 +1208,8 @@ def test_psbt_input_keys(psbt_input, keys):
12091208
self.log.info("Test descriptorprocesspsbt raises if an invalid sighashtype is passed")
12101209
assert_raises_rpc_error(-8, "'all' is not a valid sighash parameter.", self.nodes[2].descriptorprocesspsbt, psbt, [descriptor], sighashtype="all")
12111210

1212-
self.test_sighash_mismatch()
1211+
if not self.options.usecli:
1212+
self.test_sighash_mismatch()
12131213
self.test_sighash_adding()
12141214

12151215
if __name__ == '__main__':

0 commit comments

Comments
 (0)