qt, refactor: remove redundant scope in TransactionDesc::FormatTxStatus()

Author: w0xlt

src/qt/transactiondesc.cpp

@@ -34,18 +34,16 @@ using wallet::isminetype;
 
 QString TransactionDesc::FormatTxStatus(const interfaces::WalletTx& wtx, const interfaces::WalletTxStatus& status, bool inMempool, int numBlocks)
 {
-    {
-        int nDepth = status.depth_in_main_chain;
-        if (nDepth < 0) {
-            return tr("conflicted with a transaction with %1 confirmations").arg(-nDepth);
-        } else if (nDepth == 0) {
-            const QString abandoned{status.is_abandoned ? QLatin1String(", ") + tr("abandoned") : QString()};
-            return tr("0/unconfirmed, %1").arg(inMempool ? tr("in memory pool") : tr("not in memory pool")) + abandoned;
-        } else if (nDepth < 6) {
-            return tr("%1/unconfirmed").arg(nDepth);
-        } else {
-            return tr("%1 confirmations").arg(nDepth);
-        }
+    int nDepth = status.depth_in_main_chain;
+    if (nDepth < 0) {
+        return tr("conflicted with a transaction with %1 confirmations").arg(-nDepth);
+    } else if (nDepth == 0) {
+        const QString abandoned{status.is_abandoned ? QLatin1String(", ") + tr("abandoned") : QString()};
+        return tr("0/unconfirmed, %1").arg(inMempool ? tr("in memory pool") : tr("not in memory pool")) + abandoned;
+    } else if (nDepth < 6) {
+        return tr("%1/unconfirmed").arg(nDepth);
+    } else {
+        return tr("%1 confirmations").arg(nDepth);
     }
 }