random: move rand256() and randbytes() to .h file

Author: sipa

src/random.cpp

@@ -659,23 +659,6 @@ void FastRandomContext::RandomSeed()
     requires_seed = false;
 }
 
-uint256 FastRandomContext::rand256() noexcept
-{
-    uint256 ret;
-    fillrand(MakeWritableByteSpan(ret));
-    return ret;
-}
-
-template <typename B>
-std::vector<B> FastRandomContext::randbytes(size_t len)
-{
-    std::vector<B> ret(len);
-    fillrand(MakeWritableByteSpan(ret));
-    return ret;
-}
-template std::vector<unsigned char> FastRandomContext::randbytes(size_t);
-template std::vector<std::byte> FastRandomContext::randbytes(size_t);
-
 void FastRandomContext::fillrand(Span<std::byte> output)
 {
     if (requires_seed) RandomSeed();

src/random.h

@@ -213,7 +213,12 @@ class FastRandomContext
 
     /** Generate random bytes. */
     template <typename B = unsigned char>
-    std::vector<B> randbytes(size_t len);
+    std::vector<B> randbytes(size_t len)
+    {
+        std::vector<B> ret(len);
+        fillrand(MakeWritableByteSpan(ret));
+        return ret;
+    }
 
     /** Fill a byte Span with random bytes. */
     void fillrand(Span<std::byte> output);
@@ -222,7 +227,12 @@ class FastRandomContext
     uint32_t rand32() noexcept { return randbits(32); }
 
     /** generate a random uint256. */
-    uint256 rand256() noexcept;
+    uint256 rand256() noexcept
+    {
+        uint256 ret;
+        fillrand(MakeWritableByteSpan(ret));
+        return ret;
+    }
 
     /** Generate a random boolean. */
     bool randbool() noexcept { return randbits(1); }