Skip to content

Commit b544eb6

Browse files
committed
Merge #17086: tests: Fix fs_tests for unknown locales
d48f664 tests: Fix fs_tests for unknown locales (Daki Carnhof) Pull request description: Fix by removing "L" as suggested by meeDamian in bitcoin/bitcoin#14948 (comment) ``` # all in .../bitcoin/src/test $ uname -m x86_64 $ export LC_ALL=randomnonexistentlocale $ ./test_bitcoin Running 369 test cases... unknown location(0): fatal error: in "fs_tests/fsbridge_fstream": boost::system::system_error: boost::filesystem::path codecvt to string: error test/fs_tests.cpp(13): last checkpoint: "fsbridge_fstream" test entry *** 1 failure is detected in the test module "Bitcoin Core Test Suite" ``` After the patch is applied, the same test under the same conditions runs fine. ``` $ export LC_ALL=randomnonexistentlocale $ ./test_bitcoin Running 369 test cases... *** No errors detected ``` Co-Authored-By: [email protected] ACKs for top commit: laanwj: ACK d48f664 Tree-SHA512: a9910252b8ce6a05cab5530874549c2999ca2c28e835fc18aa8e5468fb417bd7d245864ec71d9233dd53e02940a9f0691b247430257f27eb0d7c20745d1c846d
2 parents a4a4964 + d48f664 commit b544eb6

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/test/fs_tests.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ BOOST_AUTO_TEST_CASE(fsbridge_fstream)
1515
fs::path tmpfolder = GetDataDir();
1616
// tmpfile1 should be the same as tmpfile2
1717
fs::path tmpfile1 = tmpfolder / "fs_tests_₿_🏃";
18-
fs::path tmpfile2 = tmpfolder / L"fs_tests_₿_🏃";
18+
fs::path tmpfile2 = tmpfolder / "fs_tests_₿_🏃";
1919
{
2020
fsbridge::ofstream file(tmpfile1);
2121
file << "bitcoin";

0 commit comments

Comments
 (0)