Skip to content

Commit b6121ed

Browse files
author
Tyler Chambers
committed
swapped "is" for "==" in literal comparison
update lint-python.sh to include check F632
1 parent 7e37329 commit b6121ed

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

contrib/devtools/security-check.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ def get_ELF_program_headers(executable):
6262
splitline = [x.strip() for x in line.split()]
6363
flags = splitline[ofs_flags]
6464
# check for 'R', ' E'
65-
if splitline[ofs_flags + 1] is 'E':
65+
if splitline[ofs_flags + 1] == 'E':
6666
flags += ' E'
6767
headers.append((typ, flags, []))
6868
count += 1

test/lint/lint-python.sh

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,7 @@ enabled=(
5555
F621 # too many expressions in an assignment with star-unpacking
5656
F622 # two or more starred expressions in an assignment (a, *b, *c = d)
5757
F631 # assertion test is a tuple, which are always True
58+
F632 # use ==/!= to compare str, bytes, and int literals
5859
F701 # a break statement outside of a while or for loop
5960
F702 # a continue statement outside of a while or for loop
6061
F703 # a continue statement in a finally block in a loop

0 commit comments

Comments
 (0)