Skip to content

Commit b6d4688

Browse files
committed
[doc] reword comments in test_mid_package_replacement
The comment about eviction seems to be erroneously copy-pasted. Reword another comment for clarity.
1 parent f3a613a commit b6d4688

File tree

1 file changed

+3
-5
lines changed

1 file changed

+3
-5
lines changed

test/functional/mempool_limit.py

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -191,9 +191,7 @@ def test_mid_package_replacement(self):
191191
current_info = node.getmempoolinfo()
192192
mempoolmin_feerate = current_info["mempoolminfee"]
193193

194-
# Mempool transaction which is evicted due to being at the "bottom" of the mempool when the
195-
# mempool overflows and evicts by descendant score. It's important that the eviction doesn't
196-
# happen in the middle of package evaluation, as it can invalidate the coins cache.
194+
# Mempool transaction is replaced by a package transaction.
197195
double_spent_utxo = self.wallet.get_utxo(confirmed_only=True)
198196
replaced_tx = self.wallet.send_self_transfer(
199197
from_node=node,
@@ -205,8 +203,8 @@ def test_mid_package_replacement(self):
205203
assert replaced_tx["txid"] in node.getrawmempool()
206204

207205
# This parent spends the above mempool transaction that exists when its inputs are first
208-
# looked up, but disappears later. It is rejected for being too low fee (but eligible for
209-
# reconsideration), and its inputs are cached. When the mempool transaction is evicted, its
206+
# looked up, but will disappear if the replacement occurs. It is rejected for being too low fee (but eligible for
207+
# reconsideration), and its inputs are cached. When the mempool transaction is replaced, its
210208
# coin is no longer available, but the cache could still contain the tx.
211209
cpfp_parent = self.wallet.create_self_transfer(
212210
utxo_to_spend=replaced_tx["new_utxo"],

0 commit comments

Comments
 (0)