Skip to content

Commit b96f6a7

Browse files
committed
Remove "conflicted" as transaction category.
We were losing information about sent/received by overriding the category in case of a conflicted transaction. Hence, remove the "conflicted" category. Conflicted status of a transaction can still be determined by looking for confirmations<0.
1 parent 76a7705 commit b96f6a7

File tree

1 file changed

+2
-8
lines changed

1 file changed

+2
-8
lines changed

src/rpcwallet.cpp

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1114,10 +1114,7 @@ void ListTransactions(const CWalletTx& wtx, const string& strAccount, int nMinDe
11141114
Object entry;
11151115
entry.push_back(Pair("account", strSentAccount));
11161116
MaybePushAddress(entry, s.first);
1117-
if (wtx.GetDepthInMainChain() < 0)
1118-
entry.push_back(Pair("category", "conflicted"));
1119-
else
1120-
entry.push_back(Pair("category", "send"));
1117+
entry.push_back(Pair("category", "send"));
11211118
entry.push_back(Pair("amount", ValueFromAmount(-s.second)));
11221119
entry.push_back(Pair("fee", ValueFromAmount(-nFee)));
11231120
if (fLong)
@@ -1150,10 +1147,7 @@ void ListTransactions(const CWalletTx& wtx, const string& strAccount, int nMinDe
11501147
}
11511148
else
11521149
{
1153-
if (wtx.GetDepthInMainChain() < 0)
1154-
entry.push_back(Pair("category", "conflicted"));
1155-
else
1156-
entry.push_back(Pair("category", "receive"));
1150+
entry.push_back(Pair("category", "receive"));
11571151
}
11581152
entry.push_back(Pair("amount", ValueFromAmount(r.second)));
11591153
if (fLong)

0 commit comments

Comments
 (0)