File tree Expand file tree Collapse file tree 1 file changed +4
-1
lines changed Expand file tree Collapse file tree 1 file changed +4
-1
lines changed Original file line number Diff line number Diff line change @@ -239,7 +239,10 @@ consensus to merge a pull request (remember that discussions may have been
239
239
spread out over GitHub, mailing list and IRC discussions). The following
240
240
language is used within pull-request comments:
241
241
242
- - ACK means "I have tested the code and I agree it should be merged";
242
+ - (t)ACK means "I have tested the code and I agree it should be merged", involving
243
+ change-specific manual testing in addition to running the unit and functional
244
+ tests, and in case it is not obvious how the manual testing was done, it should
245
+ be described;
243
246
- NACK means "I disagree this should be merged", and must be accompanied by
244
247
sound technical justification (or in certain cases of copyright/patent/licensing
245
248
issues, legal justification). NACKs without accompanying reasoning may be
You can’t perform that action at this time.
0 commit comments