wallet: Assert that the wallet is not initialized in LoadWallet

achow101 · achow101 · commit bd7f5d33e3b9 · 2023-12-11T17:03:25.000-05:00
LoadWallet() cannot be run after the wallet has been initialized. So
assert that to avoid making this mistake in the future.
diff --git a/src/wallet/wallet.cpp b/src/wallet/wallet.cpp
@@ -2292,6 +2292,8 @@ DBErrors CWallet::LoadWallet()
 {
     LOCK(cs_wallet);
 
+    Assert(m_spk_managers.empty());
+    Assert(m_wallet_flags == 0);
     DBErrors nLoadWalletRet = WalletBatch(GetDatabase()).LoadWallet(this);
     if (nLoadWalletRet == DBErrors::NEED_REWRITE)
     {

Original file line number	Diff line number	Diff line change
`@@ -2292,6 +2292,8 @@ DBErrors CWallet::LoadWallet()`
`2292`	`2292`	`{`
`2293`	`2293`	`LOCK(cs_wallet);`
`2294`	`2294`
	`2295`	`+ Assert(m_spk_managers.empty());`
	`2296`	`+ Assert(m_wallet_flags == 0);`
`2295`	`2297`	`DBErrors nLoadWalletRet = WalletBatch(GetDatabase()).LoadWallet(this);`
`2296`	`2298`	`if (nLoadWalletRet == DBErrors::NEED_REWRITE)`
`2297`	`2299`	`{`