cli, refactor: simplify DetailsRequested()

jonatack · jonatack · commit be82139b2a1e · 2025-03-12T14:10:18.000-06:00
The bounds check is no longer needed after the merge of PR 21192.
diff --git a/src/bitcoin-cli.cpp b/src/bitcoin-cli.cpp
@@ -404,7 +404,7 @@ class NetinfoRequestHandler : public BaseRequestHandler
         return UNKNOWN_NETWORK;
     }
     uint8_t m_details_level{0}; //!< Optional user-supplied arg to set dashboard details level
-    bool DetailsRequested() const { return m_details_level > 0 && m_details_level < 5; }
+    bool DetailsRequested() const { return m_details_level; }
     bool IsAddressSelected() const { return m_details_level == 2 || m_details_level == 4; }
     bool IsVersionSelected() const { return m_details_level == 3 || m_details_level == 4; }
     bool m_outbound_only_selected{false};

Original file line number	Diff line number	Diff line change
`@@ -404,7 +404,7 @@ class NetinfoRequestHandler : public BaseRequestHandler`
`404`	`404`	`return UNKNOWN_NETWORK;`
`405`	`405`	`}`
`406`	`406`	`uint8_t m_details_level{0}; //!< Optional user-supplied arg to set dashboard details level`
`407`		`- bool DetailsRequested() const { return m_details_level > 0 && m_details_level < 5; }`
	`407`	`+ bool DetailsRequested() const { return m_details_level; }`
`408`	`408`	`bool IsAddressSelected() const { return m_details_level == 2 \|\| m_details_level == 4; }`
`409`	`409`	`bool IsVersionSelected() const { return m_details_level == 3 \|\| m_details_level == 4; }`
`410`	`410`	`bool m_outbound_only_selected{false};`