Merge bitcoin/bitcoin#31480: refactor: Fix "modernize-use-starts-ends-with" clang-tidy warning

ryanofsky · ryanofsky · commit beac62e541c8 · 2024-12-12T17:13:14.000-05:00
df27ee9 refactor: Fix "modernize-use-starts-ends-with" clang-tidy warning (Hennadii Stepanov) Pull request description: This PR is a follow-up to #31306 and fixes the "modernize-use-starts-ends-with" warning in the multiprocess code (see bitcoin/bitcoin#30975 (comment)). Fixes bitcoin-core/libmultiprocess#124. ACKs for top commit: l0rinc: ACK df27ee9 theuni: utACK df27ee9 ryanofsky: Code review ACK df27ee9 Tree-SHA512: b5685818e9a3f161949b79586138e4341c5fbcc77296d5f4b13ff0183b6efaac1baea8a6d9304566f25517018d4f67b6d407105a36971a03f4077697d53f17ff
diff --git a/src/ipc/process.cpp b/src/ipc/process.cpp
@@ -72,7 +72,7 @@ static bool ParseAddress(std::string& address,
                   struct sockaddr_un& addr,
                   std::string& error)
 {
-    if (address.compare(0, 4, "unix") == 0 && (address.size() == 4 || address[4] == ':')) {
+    if (address == "unix" || address.starts_with("unix:")) {
         fs::path path;
         if (address.size() <= 5) {
             path = data_dir / fs::PathFromString(strprintf("%s.sock", RemovePrefixView(dest_exe_name, "bitcoin-")));

Original file line number	Diff line number	Diff line change
`@@ -72,7 +72,7 @@ static bool ParseAddress(std::string& address,`
`72`	`72`	`struct sockaddr_un& addr,`
`73`	`73`	`std::string& error)`
`74`	`74`	`{`
`75`		`- if (address.compare(0, 4, "unix") == 0 && (address.size() == 4 \|\| address[4] == ':')) {`
	`75`	`+ if (address == "unix" \|\| address.starts_with("unix:")) {`
`76`	`76`	`fs::path path;`
`77`	`77`	`if (address.size() <= 5) {`
`78`	`78`	`path = data_dir / fs::PathFromString(strprintf("%s.sock", RemovePrefixView(dest_exe_name, "bitcoin-")));`