Silence GCC 7 warning "control reaches end of non-void function" (-Wreturn-type) in psbt.cpp

practicalswift · practicalswift · commit beb42d71a0fd · 2019-05-02T15:08:22.000+02:00
diff --git a/src/psbt.cpp b/src/psbt.cpp
@@ -337,7 +337,9 @@ std::string PSBTRoleName(PSBTRole role) {
     case PSBTRole::SIGNER: return "signer";
     case PSBTRole::FINALIZER: return "finalizer";
     case PSBTRole::EXTRACTOR: return "extractor";
+        // no default case, so the compiler can warn about missing cases
     }
+    assert(false);
 }
 
 bool DecodeBase64PSBT(PartiallySignedTransaction& psbt, const std::string& base64_tx, std::string& error)

Original file line number	Diff line number	Diff line change
`@@ -337,7 +337,9 @@ std::string PSBTRoleName(PSBTRole role) {`
`337`	`337`	`case PSBTRole::SIGNER: return "signer";`
`338`	`338`	`case PSBTRole::FINALIZER: return "finalizer";`
`339`	`339`	`case PSBTRole::EXTRACTOR: return "extractor";`
	`340`	`+ // no default case, so the compiler can warn about missing cases`
`340`	`341`	`}`
	`342`	`+ assert(false);`
`341`	`343`	`}`
`342`	`344`
`343`	`345`	`bool DecodeBase64PSBT(PartiallySignedTransaction& psbt, const std::string& base64_tx, std::string& error)`