Merge #12426: qt: Initialize members in WalletModel

laanwj · laanwj · commit bfa39114e2cf · 2018-02-15T16:10:37.000+01:00
fa27623 qt: Initialize members in WalletModel (MarcoFalke) Pull request description: This prevents segfaults (or errors when running qt in valgrind) ``` Conditional jump or move depends on uninitialised value(s) WalletModel::checkBalanceChanged() (walletmodel.cpp:156) Tree-SHA512: 38c8c03c7fa947edb3f1c13eab2ac7a62ef8f8141603c2329a7dc5821a887a349af8014dc739b762e046f410f44a9c6653b6930f08b53496cf66381cadc06246
diff --git a/src/qt/walletmodel.cpp b/src/qt/walletmodel.cpp
@@ -42,6 +42,7 @@ WalletModel::WalletModel(const PlatformStyle *platformStyle, CWallet *_wallet, O
     transactionTableModel(0),
     recentRequestsTableModel(0),
     cachedBalance(0), cachedUnconfirmedBalance(0), cachedImmatureBalance(0),
+    cachedWatchOnlyBalance{0}, cachedWatchUnconfBalance{0}, cachedWatchImmatureBalance{0},
     cachedEncryptionStatus(Unencrypted),
     cachedNumBlocks(0)
 {

Original file line number	Diff line number	Diff line change
`@@ -42,6 +42,7 @@ WalletModel::WalletModel(const PlatformStyle platformStyle, CWallet _wallet, O`
`42`	`42`	`transactionTableModel(0),`
`43`	`43`	`recentRequestsTableModel(0),`
`44`	`44`	`cachedBalance(0), cachedUnconfirmedBalance(0), cachedImmatureBalance(0),`
	`45`	`+ cachedWatchOnlyBalance{0}, cachedWatchUnconfBalance{0}, cachedWatchImmatureBalance{0},`
`45`	`46`	`cachedEncryptionStatus(Unencrypted),`
`46`	`47`	`cachedNumBlocks(0)`
`47`	`48`	`{`