Skip to content

Commit c02d9f6

Browse files
committed
doc: net_proc: reference past defect regarding invalid GETDATA types
1 parent 5e3d9f2 commit c02d9f6

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

src/net_processing.cpp

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2426,6 +2426,9 @@ void PeerManagerImpl::ProcessGetData(CNode& pfrom, Peer& peer, const std::atomic
24262426
}
24272427
// else: If the first item on the queue is an unknown type, we erase it
24282428
// and continue processing the queue on the next call.
2429+
// NOTE: previously we wouldn't do so and the peer sending us a malformed GETDATA could
2430+
// result in never making progress and this thread using 100% allocated CPU. See
2431+
// https://bitcoincore.org/en/2024/07/03/disclose-getdata-cpu.
24292432
}
24302433

24312434
peer.m_getdata_requests.erase(peer.m_getdata_requests.begin(), it);

0 commit comments

Comments
 (0)