Skip to content

Commit c2f86d4

Browse files
fjahralfonsoromanz
andcommitted
test: Remove already resolved assumeutxo todo comments
- "Valid snapshot file, but referencing a snapshot block that turns out to be invalid, or has an invalid parent" has been addressed in #30267 - "An ancestor of snapshot block" - If chain tip refers to blocks in this context then any successful load is addressing this because if we have synced past the snapshot base block we fail because we don't need assumeutxo anymore. And if this is about headers then this is the `test_headers_not_synced()` case. - "A descendant of the snapshot block" - If this refers to blocks the `test_snapshot_with_less_work()` addressed this and if it is just headers in this case again it would be represented in all of the successful loads in the test. Co-authored-by: Alfonso Roman Zubeldia <[email protected]>
1 parent ec74f45 commit c2f86d4

File tree

1 file changed

+2
-7
lines changed

1 file changed

+2
-7
lines changed

test/functional/feature_assumeutxo.py

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -11,16 +11,9 @@
1111
1212
## Possible test improvements
1313
14-
Interesting test cases could be loading an assumeutxo snapshot file with:
15-
16-
- TODO: Valid snapshot file, but referencing a snapshot block that turns out to be
17-
invalid, or has an invalid parent
18-
1914
Interesting starting states could be loading a snapshot when the current chain tip is:
2015
21-
- TODO: An ancestor of snapshot block
2216
- TODO: The snapshot block
23-
- TODO: A descendant of the snapshot block
2417
2518
"""
2619
from shutil import rmtree
@@ -358,6 +351,8 @@ def run_test(self):
358351
self.test_snapshot_not_on_most_work_chain(dump_output['path'])
359352

360353
self.log.info(f"Loading snapshot into second node from {dump_output['path']}")
354+
# This node's tip is on an ancestor block of the snapshot, which should
355+
# be the normal case
361356
loaded = n1.loadtxoutset(dump_output['path'])
362357
assert_equal(loaded['coins_loaded'], SNAPSHOT_BASE_HEIGHT)
363358
assert_equal(loaded['base_height'], SNAPSHOT_BASE_HEIGHT)

0 commit comments

Comments
 (0)