Merge bitcoin/bitcoin#32633: windows: Use predefined RC_INVOKED macro instead of custom one

55f1c2a windows: Use predefined `RC_INVOKED` macro instead of custom one (Hennadii Stepanov)

Pull request description:

  See: https://learn.microsoft.com/en-us/windows/win32/menurc/predefined-macros.

ACKs for top commit:
  hodlinator:
    re-ACK 55f1c2a
  fanquake:
    ACK 55f1c2a

Tree-SHA512: cf18e03d0c2b1cd590e379707fc6d1775f08814f20aa51c0c40b9eac6227f42a6e07ba3e478da7d511ace29782bf964eae3edfeb04bcb1f87596966bdd3a55c9

Author: fanquake

cmake/module/AddWindowsResources.cmake

@@ -7,9 +7,6 @@ include_guard(GLOBAL)
 function(add_windows_resources target rc_file)
   if(WIN32)
     target_sources(${target} PRIVATE ${rc_file})
-    set_property(SOURCE ${rc_file}
-      APPEND PROPERTY COMPILE_DEFINITIONS WINDRES_PREPROC
-    )
   endif()
 endfunction()
 

src/clientversion.h

@@ -17,13 +17,8 @@
 //! Copyright string used in Windows .rc files
 #define COPYRIGHT_STR "2009-" STRINGIZE(COPYRIGHT_YEAR) " " COPYRIGHT_HOLDERS_FINAL
 
-/**
- * bitcoind-res.rc includes this file, but it cannot cope with real c++ code.
- * WINDRES_PREPROC is defined to indicate that its pre-processor is running.
- * Anything other than a define should be guarded below.
- */
-
-#if !defined(WINDRES_PREPROC)
+// Windows .rc files include this header, but they cannot cope with real C++ code.
+#if !defined(RC_INVOKED)
 
 #include <string>
 #include <vector>
@@ -44,6 +39,6 @@ std::string CopyrightHolders(const std::string& strPrefix);
 /** Returns licensing information (for -version) */
 std::string LicenseInfo();
 
-#endif // WINDRES_PREPROC
+#endif // RC_INVOKED
 
 #endif // BITCOIN_CLIENTVERSION_H