getrawtransaction: inform about blockhash argument when lookup fails

darosior · darosior · commit c59e3a32614e · 2019-06-14T23:02:19.000+02:00
diff --git a/src/rpc/rawtransaction.cpp b/src/rpc/rawtransaction.cpp
@@ -196,7 +196,7 @@ static UniValue getrawtransaction(const JSONRPCRequest& request)
             }
             errmsg = "No such transaction found in the provided block";
         } else if (!g_txindex) {
-            errmsg = "No such mempool transaction. Use -txindex to enable blockchain transaction queries";
+            errmsg = "No such mempool transaction. Use -txindex or provide a block hash to enable blockchain transaction queries";
         } else if (!f_txindex_ready) {
             errmsg = "No such mempool transaction. Blockchain transactions are still in the process of being indexed";
         } else {

Original file line number	Diff line number	Diff line change
`@@ -196,7 +196,7 @@ static UniValue getrawtransaction(const JSONRPCRequest& request)`
`196`	`196`	`}`
`197`	`197`	`errmsg = "No such transaction found in the provided block";`
`198`	`198`	`} else if (!g_txindex) {`
`199`		`- errmsg = "No such mempool transaction. Use -txindex to enable blockchain transaction queries";`
	`199`	`+ errmsg = "No such mempool transaction. Use -txindex or provide a block hash to enable blockchain transaction queries";`
`200`	`200`	`} else if (!f_txindex_ready) {`
`201`	`201`	`errmsg = "No such mempool transaction. Blockchain transactions are still in the process of being indexed";`
`202`	`202`	`} else {`