Skip to content

Commit c838e3b

Browse files
committed
test: add coverage for node field of getaddednodeinfo RPC
1 parent 323b0ac commit c838e3b

File tree

1 file changed

+8
-1
lines changed

1 file changed

+8
-1
lines changed

test/functional/rpc_net.py

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -249,11 +249,18 @@ def test_addnode_getaddednodeinfo(self):
249249
added_nodes = self.nodes[0].getaddednodeinfo()
250250
assert_equal(len(added_nodes), 1)
251251
assert_equal(added_nodes[0]['addednode'], ip_port)
252+
# check that filtering by node works
253+
self.nodes[0].addnode(node="11.22.33.44", command='add')
254+
first_added_node = self.nodes[0].getaddednodeinfo(node=ip_port)
255+
assert_equal(added_nodes, first_added_node)
256+
assert_equal(len(self.nodes[0].getaddednodeinfo()), 2)
252257
# check that node cannot be added again
253258
assert_raises_rpc_error(-23, "Node already added", self.nodes[0].addnode, node=ip_port, command='add')
254259
# check that node can be removed
255260
self.nodes[0].addnode(node=ip_port, command='remove')
256-
assert_equal(self.nodes[0].getaddednodeinfo(), [])
261+
added_nodes = self.nodes[0].getaddednodeinfo()
262+
assert_equal(len(added_nodes), 1)
263+
assert_equal(added_nodes[0]['addednode'], "11.22.33.44")
257264
# check that an invalid command returns an error
258265
assert_raises_rpc_error(-1, 'addnode "node" "command"', self.nodes[0].addnode, node=ip_port, command='abc')
259266
# check that trying to remove the node again returns an error

0 commit comments

Comments
 (0)