Skip to content

Commit c8839ec

Browse files
committed
refactor: use "if constexpr" in prevector's Serialize()
This gets rid of unnecessarily creating a temporary object T() to call the right function.
1 parent 1403d18 commit c8839ec

File tree

1 file changed

+10
-20
lines changed

1 file changed

+10
-20
lines changed

src/serialize.h

Lines changed: 10 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -642,8 +642,6 @@ template<typename Stream, typename C> void Unserialize(Stream& is, std::basic_st
642642
* prevector
643643
* prevectors of unsigned char are a special case and are intended to be serialized as a single opaque blob.
644644
*/
645-
template<typename Stream, unsigned int N, typename T> void Serialize_impl(Stream& os, const prevector<N, T>& v, const unsigned char&);
646-
template<typename Stream, unsigned int N, typename T, typename V> void Serialize_impl(Stream& os, const prevector<N, T>& v, const V&);
647645
template<typename Stream, unsigned int N, typename T> inline void Serialize(Stream& os, const prevector<N, T>& v);
648646
template<typename Stream, unsigned int N, typename T> void Unserialize_impl(Stream& is, prevector<N, T>& v, const unsigned char&);
649647
template<typename Stream, unsigned int N, typename T, typename V> void Unserialize_impl(Stream& is, prevector<N, T>& v, const V&);
@@ -751,24 +749,16 @@ void Unserialize(Stream& is, std::basic_string<C>& str)
751749
/**
752750
* prevector
753751
*/
754-
template<typename Stream, unsigned int N, typename T>
755-
void Serialize_impl(Stream& os, const prevector<N, T>& v, const unsigned char&)
756-
{
757-
WriteCompactSize(os, v.size());
758-
if (!v.empty())
759-
os.write(MakeByteSpan(v));
760-
}
761-
762-
template<typename Stream, unsigned int N, typename T, typename V>
763-
void Serialize_impl(Stream& os, const prevector<N, T>& v, const V&)
764-
{
765-
Serialize(os, Using<VectorFormatter<DefaultFormatter>>(v));
766-
}
767-
768-
template<typename Stream, unsigned int N, typename T>
769-
inline void Serialize(Stream& os, const prevector<N, T>& v)
770-
{
771-
Serialize_impl(os, v, T());
752+
template <typename Stream, unsigned int N, typename T>
753+
void Serialize(Stream& os, const prevector<N, T>& v)
754+
{
755+
if constexpr (std::is_same_v<T, unsigned char>) {
756+
WriteCompactSize(os, v.size());
757+
if (!v.empty())
758+
os.write(MakeByteSpan(v));
759+
} else {
760+
Serialize(os, Using<VectorFormatter<DefaultFormatter>>(v));
761+
}
772762
}
773763

774764

0 commit comments

Comments
 (0)