Extend #11583 to include the most common message generated by non-contributing peers (port scanners?)

clemtaylor · clemtaylor · commit c887f87d5960 · 2018-02-03T04:08:04.000-05:00
37% of the log default log entries for a node that has been up for ~24hrs was "version handshake timeout..."
diff --git a/src/net.cpp b/src/net.cpp
@@ -1431,7 +1431,7 @@ void CConnman::ThreadSocketHandler()
                 }
                 else if (!pnode->fSuccessfullyConnected)
                 {
-                    LogPrintf("version handshake timeout from %d\n", pnode->GetId());
+                    LogPrint(BCLog::NET, "version handshake timeout from %d\n", pnode->GetId());
                     pnode->fDisconnect = true;
                 }
             }

Original file line number	Diff line number	Diff line change
`@@ -1431,7 +1431,7 @@ void CConnman::ThreadSocketHandler()`
`1431`	`1431`	`}`
`1432`	`1432`	`else if (!pnode->fSuccessfullyConnected)`
`1433`	`1433`	`{`
`1434`		`- LogPrintf("version handshake timeout from %d\n", pnode->GetId());`
	`1434`	`+ LogPrint(BCLog::NET, "version handshake timeout from %d\n", pnode->GetId());`
`1435`	`1435`	`pnode->fDisconnect = true;`
`1436`	`1436`	`}`
`1437`	`1437`	`}`