init: Remove confusing '(possible integer overflow?)' from error message

laanwj · laanwj · commit cf79c56e6559 · 2022-02-03T13:36:56.000+01:00
diff --git a/src/init.cpp b/src/init.cpp
@@ -1131,7 +1131,7 @@ bool AppInitMain(NodeContext& node, interfaces::BlockAndHeaderTipInfo* tip_info)
 
     auto opt_max_upload = ParseByteUnits(args.GetArg("-maxuploadtarget", DEFAULT_MAX_UPLOAD_TARGET), ByteUnit::M);
     if (!opt_max_upload) {
-        return InitError(strprintf(_("Unable to parse -maxuploadtarget: '%s' (possible integer overflow?)"), args.GetArg("-maxuploadtarget", "")));
+        return InitError(strprintf(_("Unable to parse -maxuploadtarget: '%s'"), args.GetArg("-maxuploadtarget", "")));
     }
 
     // ********************************************************* Step 4a: application initialization

Original file line number	Diff line number	Diff line change
`@@ -1131,7 +1131,7 @@ bool AppInitMain(NodeContext& node, interfaces::BlockAndHeaderTipInfo* tip_info)`
`1131`	`1131`
`1132`	`1132`	`auto opt_max_upload = ParseByteUnits(args.GetArg("-maxuploadtarget", DEFAULT_MAX_UPLOAD_TARGET), ByteUnit::M);`
`1133`	`1133`	`if (!opt_max_upload) {`
`1134`		`- return InitError(strprintf(_("Unable to parse -maxuploadtarget: '%s' (possible integer overflow?)"), args.GetArg("-maxuploadtarget", "")));`
	`1134`	`+ return InitError(strprintf(_("Unable to parse -maxuploadtarget: '%s'"), args.GetArg("-maxuploadtarget", "")));`
`1135`	`1135`	`}`
`1136`	`1136`
`1137`	`1137`	`// ********************************************************* Step 4a: application initialization`