wallet, refactor: Remove Legacy check and error

pablomartin4btc · pablomartin4btc · commit d3c5e47391e2 · 2025-08-22T16:49:14.000-03:00
Remove dead code due to legacy wallet removal.
diff --git a/src/wallet/wallet.cpp b/src/wallet/wallet.cpp
@@ -3656,9 +3656,7 @@ util::Result<std::reference_wrapper<DescriptorScriptPubKeyMan>> CWallet::AddWall
 {
     AssertLockHeld(cs_wallet);
 
-    if (!IsWalletFlagSet(WALLET_FLAG_DESCRIPTORS)) {
-        return util::Error{_("Cannot add WalletDescriptor to a non-descriptor wallet")};
-    }
+    Assert(IsWalletFlagSet(WALLET_FLAG_DESCRIPTORS));
 
     auto spk_man = GetDescriptorScriptPubKeyMan(desc);
     if (spk_man) {

Original file line number	Diff line number	Diff line change
`@@ -3656,9 +3656,7 @@ util::Result<std::reference_wrapper<DescriptorScriptPubKeyMan>> CWallet::AddWall`
`3656`	`3656`	`{`
`3657`	`3657`	`AssertLockHeld(cs_wallet);`
`3658`	`3658`
`3659`		`- if (!IsWalletFlagSet(WALLET_FLAG_DESCRIPTORS)) {`
`3660`		`- return util::Error{_("Cannot add WalletDescriptor to a non-descriptor wallet")};`
`3661`		`- }`
	`3659`	`+ Assert(IsWalletFlagSet(WALLET_FLAG_DESCRIPTORS));`
`3662`	`3660`
`3663`	`3661`	`auto spk_man = GetDescriptorScriptPubKeyMan(desc);`
`3664`	`3662`	`if (spk_man) {`