Skip to content

Commit d4187e4

Browse files
committed
[test] Use mocktime in test_seed_peers()
Test case now takes < 5 seconds instead of > 2 minutes
1 parent 015637d commit d4187e4

File tree

1 file changed

+13
-12
lines changed

1 file changed

+13
-12
lines changed

test/functional/feature_config_args.py

Lines changed: 13 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -149,20 +149,21 @@ def test_networkactive(self):
149149
self.stop_node(0)
150150

151151
def test_seed_peers(self):
152-
self.log.info('Test seed peers, this will take about 2 minutes')
152+
self.log.info('Test seed peers')
153153
default_data_dir = self.nodes[0].datadir
154154

155155
# No peers.dat exists and -dnsseed=1
156156
# We expect the node will use DNS Seeds, but Regtest mode has 0 DNS seeds
157157
# So after 60 seconds, the node should fallback to fixed seeds (this is a slow test)
158158
assert not os.path.exists(os.path.join(default_data_dir, "peers.dat"))
159-
start = time.time()
159+
start = int(time.time())
160160
with self.nodes[0].assert_debug_log(expected_msgs=[
161161
"Loaded 0 addresses from peers.dat",
162-
"0 addresses found from DNS seeds",
163-
"Adding fixed seeds as 60 seconds have passed and addrman is empty"], timeout=80):
164-
self.start_node(0, extra_args=['-dnsseed=1'])
165-
assert time.time() - start >= 60
162+
"0 addresses found from DNS seeds"]):
163+
self.start_node(0, extra_args=['-dnsseed=1 -mocktime={}'.format(start)])
164+
with self.nodes[0].assert_debug_log(expected_msgs=[
165+
"Adding fixed seeds as 60 seconds have passed and addrman is empty"]):
166+
self.nodes[0].setmocktime(start + 65)
166167
self.stop_node(0)
167168

168169
# No peers.dat exists and -dnsseed=0
@@ -192,14 +193,14 @@ def test_seed_peers(self):
192193
# No peers.dat exists and -dnsseed=0, but a -addnode is provided
193194
# We expect the node will allow 60 seconds prior to using fixed seeds
194195
assert not os.path.exists(os.path.join(default_data_dir, "peers.dat"))
195-
start = time.time()
196+
start = int(time.time())
196197
with self.nodes[0].assert_debug_log(expected_msgs=[
197198
"Loaded 0 addresses from peers.dat",
198-
"DNS seeding disabled",
199-
"Adding fixed seeds as 60 seconds have passed and addrman is empty"],
200-
timeout=80):
201-
self.start_node(0, extra_args=['-dnsseed=0', '-addnode=fakenodeaddr'])
202-
assert time.time() - start >= 60
199+
"DNS seeding disabled"]):
200+
self.start_node(0, extra_args=['-dnsseed=0', '-addnode=fakenodeaddr -mocktime={}'.format(start)])
201+
with self.nodes[0].assert_debug_log(expected_msgs=[
202+
"Adding fixed seeds as 60 seconds have passed and addrman is empty"]):
203+
self.nodes[0].setmocktime(start + 65)
203204
self.stop_node(0)
204205

205206

0 commit comments

Comments
 (0)