Skip to content

Commit d6c37b2

Browse files
committed
qa: remove unnecessary tx removal from compact block
The error being checked here is BLOCK_MUTATED, as returned by IsBlockMutated() in FillBlock(). Dropping the fourth transaction from the block is unnecessary and would make testing of other block validation failures in following commits more verbose.
1 parent 3219847 commit d6c37b2

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

test/functional/p2p_compactblocks.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -709,7 +709,6 @@ def test_invalid_tx_in_compactblock(self, test_node):
709709
utxo = self.utxos[0]
710710

711711
block = self.build_block_with_transactions(node, utxo, 5)
712-
del block.vtx[3]
713712
block.hashMerkleRoot = block.calc_merkle_root()
714713
# Drop the coinbase witness but include the witness commitment.
715714
add_witness_commitment(block)

0 commit comments

Comments
 (0)