Skip to content

Commit d8794a7

Browse files
author
MarcoFalke
committed
Merge #13787: Test for Windows encoding issue
15b3103 appveyor: Remove outdated libraries (Chun Kuan Lee) ae892ad tests: accept unicode characters on Windows (Chun Kuan Lee) Pull request description: This PR removes unused Windows compatible path. Encoding issues has been solved. Tree-SHA512: d24dce035fe3b576eaa002896f815a6691e88618ea371171d7e39883e1d63b3ed4d4631ab3b3a26bd67ae4e8ae13b1ff188942ab7ac6a93d704e0de301368cd0
2 parents 03732f8 + 15b3103 commit d8794a7

File tree

2 files changed

+1
-4
lines changed

2 files changed

+1
-4
lines changed

.appveyor.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ install:
1717
- cmd: pip install --quiet git+https://github.com/frerich/[email protected]
1818
# Disable zmq test for now since python zmq library on Windows would cause Access violation sometimes.
1919
# - cmd: pip install zmq
20+
- cmd: vcpkg remove --outdated --recurse
2021
- cmd: vcpkg install --triplet %PLATFORM%-windows-static %PACKAGES% > NUL
2122
- cmd: del /s /q C:\Tools\vcpkg\installed\%PLATFORM%-windows-static\debug # Remove unused debug library
2223
before_build:

test/functional/test_runner.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -250,10 +250,6 @@ def main():
250250
# Create base test directory
251251
tmpdir = "%s/test_runner_₿_🏃_%s" % (args.tmpdirprefix, datetime.datetime.now().strftime("%Y%m%d_%H%M%S"))
252252

253-
# If we fixed the command-line and filename encoding issue on Windows, these two lines could be removed
254-
if config["environment"]["EXEEXT"] == ".exe":
255-
tmpdir = "%s/test_runner_%s" % (args.tmpdirprefix, datetime.datetime.now().strftime("%Y%m%d_%H%M%S"))
256-
257253
os.makedirs(tmpdir)
258254

259255
logging.debug("Temporary test directory at %s" % tmpdir)

0 commit comments

Comments
 (0)