refactor: Get rid of BanMan::BannedSetIsDirty()

Author: hebasto

src/banman.cpp

@@ -53,7 +53,7 @@ void BanMan::DumpBanlist()
     {
         LOCK(m_cs_banned);
         SweepBanned();
-        if (!BannedSetIsDirty()) return;
+        if (!m_is_dirty) return;
         banmap = m_banned;
         SetBannedSetDirty(false);
     }
@@ -203,12 +203,6 @@ void BanMan::SweepBanned()
     }
 }
 
-bool BanMan::BannedSetIsDirty()
-{
-    LOCK(m_cs_banned);
-    return m_is_dirty;
-}
-
 void BanMan::SetBannedSetDirty(bool dirty)
 {
     LOCK(m_cs_banned); //reuse m_banned lock for the m_is_dirty flag

src/banman.h

@@ -81,7 +81,6 @@ class BanMan
 
 private:
     void LoadBanlist() EXCLUSIVE_LOCKS_REQUIRED(!m_cs_banned);
-    bool BannedSetIsDirty();
     //!set the "dirty" flag for the banlist
     void SetBannedSetDirty(bool dirty = true);
     //!clean unused entries (if bantime has expired)