Skip to content

Commit d88d1f8

Browse files
author
MarcoFalke
committed
Merge #14937: travis: fix travis would always be green even if it fail
fc91c1f Revert "travis: Save cache on build error" (Chun Kuan Lee) Pull request description: The current travis-ci job would fail only if the last command failed. It would be succeed if other commands than the last one fail. This PR execute the script in another shell instance, so we should export those variables and bash functions. It would return 1 if the script fail no matter if it's the last command. Sorry for ruin the travis ci system in #14231 Test: https://travis-ci.org/ken2812221/bitcoin/jobs/467086010 Tree-SHA512: 4d9d144fe4c7038b4eff6bf8496e821af603d81677142c0884ed52aea6ce3a50150669be4fdad72a5d372456a33a2452d75ec35e8a7ec2bc4bdfbeaeb93e9acb
2 parents 914faf1 + fc91c1f commit d88d1f8

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

.travis.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -26,13 +26,13 @@ env:
2626
- WINEDEBUG=fixme-all
2727
- DOCKER_PACKAGES="build-essential libtool autotools-dev automake pkg-config bsdmainutils curl git ca-certificates ccache"
2828
before_install:
29-
- set -o errexit; if ! source .travis/test_03_before_install.sh; then set +o errexit; false; fi
29+
- set -o errexit; source .travis/test_03_before_install.sh
3030
install:
31-
- set -o errexit; if ! source .travis/test_04_install.sh; then set +o errexit; false; fi
31+
- set -o errexit; source .travis/test_04_install.sh
3232
before_script:
33-
- set -o errexit; if ! source .travis/test_05_before_script.sh; then set +o errexit; false; fi
33+
- set -o errexit; source .travis/test_05_before_script.sh
3434
script:
35-
- if [ $SECONDS -gt 1200 ]; then set +o errexit; echo "Travis early exit to cache current state"; false; else set -o errexit; if ! source .travis/test_06_script.sh; then set +o errexit; false; fi; fi
35+
- if [ $SECONDS -gt 1200 ]; then set +o errexit; echo "Travis early exit to cache current state"; false; else set -o errexit; source .travis/test_06_script.sh; fi
3636
after_script:
3737
- echo $TRAVIS_COMMIT_RANGE
3838
- echo $TRAVIS_COMMIT_LOG

0 commit comments

Comments
 (0)