Skip to content

Commit d926a87

Browse files
committed
Merge #14247: Fix crash bug with duplicate inputs within a transaction
9b4a36e [qa] Test for duplicate inputs within a transaction (Suhas Daftuar) b8f8019 Fix crash bug with duplicate inputs within a transaction (Suhas Daftuar) Pull request description: Tree-SHA512: 8c7ea34c7fa44188d86c04a690a7cbf8e9deda71ab1f7ca6d11de1f2abb3dd7222627071f86d0d39689a8b302ba9af142f0202466a67e30cd54aed3a08d4eb14
2 parents 4901c00 + 9b4a36e commit d926a87

File tree

2 files changed

+11
-1
lines changed

2 files changed

+11
-1
lines changed

src/validation.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3122,7 +3122,7 @@ bool CheckBlock(const CBlock& block, CValidationState& state, const Consensus::P
31223122

31233123
// Check transactions
31243124
for (const auto& tx : block.vtx)
3125-
if (!CheckTransaction(*tx, state, false))
3125+
if (!CheckTransaction(*tx, state, true))
31263126
return state.Invalid(false, state.GetRejectCode(), state.GetRejectReason(),
31273127
strprintf("Transaction check failed (tx hash %s) %s", tx->GetHash().ToString(), state.GetDebugMessage()));
31283128

test/functional/p2p_invalid_block.py

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -81,6 +81,16 @@ def run_test(self):
8181

8282
node.p2p.send_blocks_and_test([block2], node, success=False, request_block=False, reject_reason='bad-txns-duplicate')
8383

84+
# Check transactions for duplicate inputs
85+
self.log.info("Test duplicate input block.")
86+
87+
block2_orig.vtx[2].vin.append(block2_orig.vtx[2].vin[0])
88+
block2_orig.vtx[2].rehash()
89+
block2_orig.hashMerkleRoot = block2_orig.calc_merkle_root()
90+
block2_orig.rehash()
91+
block2_orig.solve()
92+
node.p2p.send_blocks_and_test([block2_orig], node, success=False, request_block=False, reject_reason='bad-txns-inputs-duplicate')
93+
8494
self.log.info("Test very broken block.")
8595

8696
block3 = create_block(tip, create_coinbase(height), block_time)

0 commit comments

Comments
 (0)