Skip to content

Commit da318fe

Browse files
committed
test: delete commented out tests
1 parent 6d80e99 commit da318fe

File tree

1 file changed

+0
-32
lines changed

1 file changed

+0
-32
lines changed

test/functional/wallet_signer.py

Lines changed: 0 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,6 @@ def test_valid_signer(self):
7878
assert_equal(not_hww.getwalletinfo()["external_signer"], False)
7979
assert_raises_rpc_error(-8, "Wallet flag is immutable: external_signer", not_hww.setwalletflag, "external_signer", True)
8080

81-
# assert_raises_rpc_error(-4, "Multiple signers found, please specify which to use", wallet_name='not_hww', disable_private_keys=True, external_signer=True)
8281

8382
self.set_mock_result(self.nodes[1], '0 {"invalid json"}')
8483
assert_raises_rpc_error(-1, 'Unable to parse JSON',
@@ -167,31 +166,6 @@ def test_valid_signer(self):
167166
mock_tx = mock_psbt_signed["hex"]
168167
assert mock_wallet.testmempoolaccept([mock_tx])[0]["allowed"]
169168

170-
# # Create a new wallet and populate with specific public keys, in order
171-
# # to work with the mock signed PSBT.
172-
# self.nodes[1].createwallet(wallet_name="hww4", disable_private_keys=True, external_signer=True)
173-
# hww4 = self.nodes[1].get_wallet_rpc("hww4")
174-
#
175-
# descriptors = [{
176-
# "desc": "wpkh([00000001/84h/1h/0']tpubD6NzVbkrYhZ4WaWSyoBvQwbpLkojyoTZPRsgXELWz3Popb3qkjcJyJUGLnL4qHHoQvao8ESaAstxYSnhyswJ76uZPStJRJCTKvosUCJZL5B/0/*)#x30uthjs",
177-
# "timestamp": "now",
178-
# "range": [0, 1],
179-
# "internal": False,
180-
# "watchonly": True,
181-
# "active": True
182-
# },
183-
# {
184-
# "desc": "wpkh([00000001/84h/1h/0']tpubD6NzVbkrYhZ4WaWSyoBvQwbpLkojyoTZPRsgXELWz3Popb3qkjcJyJUGLnL4qHHoQvao8ESaAstxYSnhyswJ76uZPStJRJCTKvosUCJZL5B/1/*)#h92akzzg",
185-
# "timestamp": "now",
186-
# "range": [0, 0],
187-
# "internal": True,
188-
# "watchonly": True,
189-
# "active": True
190-
# }]
191-
192-
# result = hww4.importdescriptors(descriptors)
193-
# assert_equal(result[0], {'success': True})
194-
# assert_equal(result[1], {'success': True})
195169
assert_equal(hww.getwalletinfo()["txcount"], 1)
196170

197171
assert hww.testmempoolaccept([mock_tx])[0]["allowed"]
@@ -231,12 +205,6 @@ def test_valid_signer(self):
231205
assert_greater_than(res["fee"], res["origfee"])
232206
assert_equal(res["errors"], [])
233207

234-
# # Handle error thrown by script
235-
# self.set_mock_result(self.nodes[4], "2")
236-
# assert_raises_rpc_error(-1, 'Unable to parse JSON',
237-
# hww4.signerprocesspsbt, psbt_orig, "00000001"
238-
# )
239-
# self.clear_mock_result(self.nodes[4])
240208

241209
def test_disconnected_signer(self):
242210
self.log.info('Test disconnected external signer')

0 commit comments

Comments
 (0)