Merge #21364: fuzz: Avoid -Wreturn-type warnings

fanquake · fanquake · commit da8c7edffe0c · 2021-03-05T10:42:38.000+08:00
3f36468 fuzz: Avoid -Wreturn-type warnings (practicalswift) Pull request description: Avoid `-Wreturn-type` warnings. Closes #21355. ACKs for top commit: MarcoFalke: cr ACK 3f36468 fanquake: ACK 3f36468 - thanks for cleaning this up. Tree-SHA512: 6fa2640a26e64d2bea60e016ad14b5c434137fedc0b3bf2ac244f02f9b1cd303d1ebac4ac4e6791534560f8311c4cbe9395c2ce94d7ec022d3b192f1ea070809
diff --git a/src/test/fuzz/util.h b/src/test/fuzz/util.h
@@ -10,6 +10,7 @@
 #include <attributes.h>
 #include <chainparamsbase.h>
 #include <coins.h>
+#include <compat.h>
 #include <consensus/consensus.h>
 #include <merkleblock.h>
 #include <net.h>
@@ -545,11 +546,13 @@ class FuzzedSock : public Sock
     SOCKET Get() const override
     {
         assert(false && "Not implemented yet.");
+        return INVALID_SOCKET;
     }
 
     SOCKET Release() override
     {
         assert(false && "Not implemented yet.");
+        return INVALID_SOCKET;
     }
 
     void Reset() override

Original file line number	Diff line number	Diff line change
`@@ -10,6 +10,7 @@`
`10`	`10`	`#include <attributes.h>`
`11`	`11`	`#include <chainparamsbase.h>`
`12`	`12`	`#include <coins.h>`
	`13`	`+#include <compat.h>`
`13`	`14`	`#include <consensus/consensus.h>`
`14`	`15`	`#include <merkleblock.h>`
`15`	`16`	`#include <net.h>`
`@@ -545,11 +546,13 @@ class FuzzedSock : public Sock`
`545`	`546`	`SOCKET Get() const override`
`546`	`547`	`{`
`547`	`548`	`assert(false && "Not implemented yet.");`
	`549`	`+ return INVALID_SOCKET;`
`548`	`550`	`}`
`549`	`551`
`550`	`552`	`SOCKET Release() override`
`551`	`553`	`{`
`552`	`554`	`assert(false && "Not implemented yet.");`
	`555`	`+ return INVALID_SOCKET;`
`553`	`556`	`}`
`554`	`557`
`555`	`558`	`void Reset() override`