Skip to content

Commit db6eb90

Browse files
committed
[doc] Remove outdated comment about mining code ignoring CPFP
BlockAssembler chooses transactions on the basis of packages (which incorporate unconfirmed ancestors into feerate), so the specified RBF comment about mining code ignoring CPFP is out of date.
1 parent 88a15eb commit db6eb90

File tree

1 file changed

+5
-7
lines changed

1 file changed

+5
-7
lines changed

src/validation.cpp

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -806,13 +806,11 @@ static bool AcceptToMemoryPoolWorker(const CChainParams& chainparams, CTxMemPool
806806
// be increased is also an easy-to-reason about way to prevent
807807
// DoS attacks via replacements.
808808
//
809-
// The mining code doesn't (currently) take children into
810-
// account (CPFP) so we only consider the feerates of
811-
// transactions being directly replaced, not their indirect
812-
// descendants. While that does mean high feerate children are
813-
// ignored when deciding whether or not to replace, we do
814-
// require the replacement to pay more overall fees too,
815-
// mitigating most cases.
809+
// We only consider the feerates of transactions being directly
810+
// replaced, not their indirect descendants. While that does
811+
// mean high feerate children are ignored when deciding whether
812+
// or not to replace, we do require the replacement to pay more
813+
// overall fees too, mitigating most cases.
816814
CFeeRate oldFeeRate(mi->GetModifiedFee(), mi->GetTxSize());
817815
if (newFeeRate <= oldFeeRate)
818816
{

0 commit comments

Comments
 (0)