Merge bitcoin/bitcoin#28124: fuzz: Re-enable symbolize=1 in ASAN_OPTIONS

fanquake · fanquake · commit e35fb7bc48d3 · 2023-07-25T10:47:06.000+01:00
faa8c1b fuzz: Re-enable symbolize=1 in ASAN_OPTIONS (MarcoFalke) Pull request description: Looks like this fixed itself somehow and is no longer reproducible? ACKs for top commit: fanquake: ACK faa8c1b Tree-SHA512: 67d2d6349cc7485f32bebabc18869ab101ae66a778a40ff9ddb037980997e600d7c6d1e0a17a011fa2a4ba07c73594b087dd781248cb8351f2688bc4cf6e587d
diff --git a/test/fuzz/test_runner.py b/test/fuzz/test_runner.py
@@ -20,8 +20,7 @@ def get_fuzz_env(*, target, source_dir):
         'FUZZ': target,
         'UBSAN_OPTIONS':
         f'suppressions={source_dir}/test/sanitizer_suppressions/ubsan:print_stacktrace=1:halt_on_error=1:report_error_type=1',
-        'ASAN_OPTIONS':  # symbolizer disabled due to https://github.com/google/sanitizers/issues/1364#issuecomment-761072085
-        'symbolize=0:detect_stack_use_after_return=1:check_initialization_order=1:strict_init_order=1',
+        "ASAN_OPTIONS": "detect_stack_use_after_return=1:check_initialization_order=1:strict_init_order=1",
     }
 
 

Original file line number	Diff line number	Diff line change
`@@ -20,8 +20,7 @@ def get_fuzz_env(*, target, source_dir):`
`20`	`20`	`'FUZZ': target,`
`21`	`21`	`'UBSAN_OPTIONS':`
`22`	`22`	`f'suppressions={source_dir}/test/sanitizer_suppressions/ubsan:print_stacktrace=1:halt_on_error=1:report_error_type=1',`
`23`		`- 'ASAN_OPTIONS': # symbolizer disabled due to https://github.com/google/sanitizers/issues/1364#issuecomment-761072085`
`24`		`- 'symbolize=0:detect_stack_use_after_return=1:check_initialization_order=1:strict_init_order=1',`
	`23`	`+ "ASAN_OPTIONS": "detect_stack_use_after_return=1:check_initialization_order=1:strict_init_order=1",`
`25`	`24`	`}`
`26`	`25`
`27`	`26`