Merge bitcoin/bitcoin#28194: test: python E721 and flake8 updates

bee2d57 script: update flake8 to 6.1.0 (Jon Atack)
38c3fd8 test: python E721 updates (Jon Atack)

Pull request description:

  Update our functional tests per [E721](https://www.flake8rules.com/rules/E721.html) enforced by [flake8 6.1.0](https://flake8.pycqa.org/en/latest/release-notes/6.1.0.html), and update our CI lint task to use that release.  This makes the following linter output on current master with flake8 6.1.0 green.

  ```
  $ ./test/lint/lint-python.py ; ./test/lint/lint-spelling.py
  test/functional/p2p_invalid_locator.py:35:16: E721 do not compare types, for exact checks use `is` / `is not`, for instance checks use `isinstance()`
  test/functional/test_framework/siphash.py:34:12: E721 do not compare types, for exact checks use `is` / `is not`, for instance checks use `isinstance()`
  test/functional/test_framework/siphash.py:64:12: E721 do not compare types, for exact checks use `is` / `is not`, for instance checks use `isinstance()`
  src/test/fuzz/descriptor_parse.cpp:88: occurences ==> occurrences
  ^ Warning: codespell identified likely spelling errors. Any false positives? Add them to the list of ignored words in test/lint/spelling.ignore-words.txt
  ```

ACKs for top commit:
  MarcoFalke:
    lgtm ACK bee2d57

Tree-SHA512: f3788a543ca98e44eeeba1d06c32f1b11eec95d4aef068aa1b6b5c401261adfa3fb6c6d6c769f3fe6839d78e74a310d5c926867e7c367d6513a53d580fd376f3

Author: fanquake

ci/lint/04_install.sh

@@ -35,7 +35,7 @@ python3 --version
 
 ${CI_RETRY_EXE} pip3 install \
   codespell==2.2.5 \
-  flake8==6.0.0 \
+  flake8==6.1.0 \
   lief==0.13.2 \
   mypy==1.4.1 \
   pyzmq==25.1.0 \

src/test/fuzz/descriptor_parse.cpp

@@ -85,7 +85,7 @@ class MockedDescriptorConverter {
         std::string desc;
         desc.reserve(mocked_desc.size());
 
-        // Replace all occurences of '%' followed by two hex characters with the corresponding key.
+        // Replace all occurrences of '%' followed by two hex characters with the corresponding key.
         for (size_t i = 0; i < mocked_desc.size();) {
             if (mocked_desc[i] == '%') {
                 if (i + 3 >= mocked_desc.size()) return {};

test/functional/p2p_invalid_locator.py

@@ -32,7 +32,7 @@ def run_test(self):
             within_max_peer = node.add_p2p_connection(P2PInterface())
             msg.locator.vHave = [int(node.getblockhash(i - 1), 16) for i in range(block_count, block_count - (MAX_LOCATOR_SZ), -1)]
             within_max_peer.send_message(msg)
-            if type(msg) == msg_getheaders:
+            if type(msg) is msg_getheaders:
                 within_max_peer.wait_for_header(node.getbestblockhash())
             else:
                 within_max_peer.wait_for_block(int(node.getbestblockhash(), 16))

test/functional/test_framework/siphash.py

@@ -31,7 +31,7 @@ def siphash_round(v0, v1, v2, v3):
 
 
 def siphash(k0, k1, data):
-    assert type(data) == bytes
+    assert type(data) is bytes
     v0 = 0x736f6d6570736575 ^ k0
     v1 = 0x646f72616e646f6d ^ k1
     v2 = 0x6c7967656e657261 ^ k0
@@ -61,5 +61,5 @@ def siphash(k0, k1, data):
 
 
 def siphash256(k0, k1, num):
-    assert type(num) == int
+    assert type(num) is int
     return siphash(k0, k1, num.to_bytes(32, 'little'))