RPC: submitblock: Support for returning specific rejection reasons

luke-jr · luke-jr · commit e69a5873e705 · 2014-10-30T02:03:43.000Z
diff --git a/src/rpcmining.cpp b/src/rpcmining.cpp
@@ -592,7 +592,12 @@ Value submitblock(const Array& params, bool fHelp)
         throw JSONRPCError(RPC_VERIFY_ERROR, strRejectReason);
     }
     if (state.IsInvalid())
-        return "rejected"; // TODO: report validation state
+    {
+        std::string strRejectReason = state.GetRejectReason();
+        if (strRejectReason.empty())
+            return "rejected";
+        return strRejectReason;
+    }
 
     return Value::null;
 }

Original file line number	Diff line number	Diff line change
`@@ -592,7 +592,12 @@ Value submitblock(const Array& params, bool fHelp)`
`592`	`592`	`throw JSONRPCError(RPC_VERIFY_ERROR, strRejectReason);`
`593`	`593`	`}`
`594`	`594`	`if (state.IsInvalid())`
`595`		`- return "rejected"; // TODO: report validation state`
	`595`	`+ {`
	`596`	`+ std::string strRejectReason = state.GetRejectReason();`
	`597`	`+ if (strRejectReason.empty())`
	`598`	`+ return "rejected";`
	`599`	`+ return strRejectReason;`
	`600`	`+ }`
`596`	`601`
`597`	`602`	`return Value::null;`
`598`	`603`	`}`