Skip to content

Commit eb0724f

Browse files
committed
doc: banman: reference past vuln due to unbounded banlist
1 parent ad616b6 commit eb0724f

File tree

1 file changed

+5
-0
lines changed

1 file changed

+5
-0
lines changed

src/banman.h

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,11 @@ class CSubNet;
5454
// transaction that fails a policy check and a future version changes the
5555
// policy check so the transaction is accepted, then that transaction could
5656
// cause the network to split between old nodes and new nodes.
57+
//
58+
// NOTE: previously a misbehaving peer would get banned instead of discouraged.
59+
// This meant a peer could unboundedly grow our in-memory map of banned ips. When
60+
// receiving an ADDR message we would also compare every address received to every
61+
// item in the map. See https://bitcoincore.org/en/2024/07/03/disclose-unbounded-banlist.
5762

5863
class BanMan
5964
{

0 commit comments

Comments
 (0)