Skip to content

Commit ee3ba5a

Browse files
author
MacroFake
committed
Merge bitcoin/bitcoin#25485: rpc: Use enum instead of string for filtertype_name
baf4efe rpc: use enum instead of string for filter type (w0xlt) Pull request description: This PR changes the `getblockfilter` RPC to use `BlockFilterType` enum instead of a repeated string for `filtertype_name`. ACKs for top commit: furszy: ACK baf4efe brunoerg: ACK baf4efe Tree-SHA512: 31c79c0a5f0b17fd69b399bb026f523003b656733d6b7d5ffe665921a8cc0f1e0334d2e465145cd89fbd85e196059cf56f4f11563bbc92948b0606080ca76524
2 parents 2111f32 + baf4efe commit ee3ba5a

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

src/rpc/blockchain.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2177,7 +2177,7 @@ static RPCHelpMan getblockfilter()
21772177
"\nRetrieve a BIP 157 content filter for a particular block.\n",
21782178
{
21792179
{"blockhash", RPCArg::Type::STR_HEX, RPCArg::Optional::NO, "The hash of the block"},
2180-
{"filtertype", RPCArg::Type::STR, RPCArg::Default{"basic"}, "The type name of the filter"},
2180+
{"filtertype", RPCArg::Type::STR, RPCArg::Default{BlockFilterTypeName(BlockFilterType::BASIC)}, "The type name of the filter"},
21812181
},
21822182
RPCResult{
21832183
RPCResult::Type::OBJ, "", "",
@@ -2192,7 +2192,7 @@ static RPCHelpMan getblockfilter()
21922192
[&](const RPCHelpMan& self, const JSONRPCRequest& request) -> UniValue
21932193
{
21942194
uint256 block_hash = ParseHashV(request.params[0], "blockhash");
2195-
std::string filtertype_name = "basic";
2195+
std::string filtertype_name = BlockFilterTypeName(BlockFilterType::BASIC);
21962196
if (!request.params[1].isNull()) {
21972197
filtertype_name = request.params[1].get_str();
21982198
}

0 commit comments

Comments
 (0)