Merge #20271: doc: Document that wallet salvage is experimental

meshcollider · meshcollider · commit f1fcbdea2555 · 2020-11-02T11:52:49.000+13:00
fab9453 doc: Document that wallet salvage is experimental (MarcoFalke) Pull request description: See #20151 ACKs for top commit: practicalswift: ACK fab9453: user safety first hebasto: ACK fab9453, maybe capitalize into "WARNING"? meshcollider: Trivial ACK fab9453 Tree-SHA512: 94912c491facc485293e4333066057933d706d84c7172f615296e7ba998c583c8bd07e751e6f00cd6576e7791007ace321f959181f7bf6a4e15e10d7ec8a1b7e
diff --git a/src/bitcoin-wallet.cpp b/src/bitcoin-wallet.cpp
@@ -31,7 +31,7 @@ static void SetupWalletToolArgs(ArgsManager& argsman)
 
     argsman.AddArg("info", "Get wallet info", ArgsManager::ALLOW_ANY, OptionsCategory::COMMANDS);
     argsman.AddArg("create", "Create new wallet file", ArgsManager::ALLOW_ANY, OptionsCategory::COMMANDS);
-    argsman.AddArg("salvage", "Attempt to recover private keys from a corrupt wallet", ArgsManager::ALLOW_ANY, OptionsCategory::COMMANDS);
+    argsman.AddArg("salvage", "Attempt to recover private keys from a corrupt wallet. Warning: 'salvage' is experimental.", ArgsManager::ALLOW_ANY, OptionsCategory::COMMANDS);
 }
 
 static bool WalletAppInit(int argc, char* argv[])

Original file line number	Diff line number	Diff line change
`@@ -31,7 +31,7 @@ static void SetupWalletToolArgs(ArgsManager& argsman)`
`31`	`31`
`32`	`32`	`argsman.AddArg("info", "Get wallet info", ArgsManager::ALLOW_ANY, OptionsCategory::COMMANDS);`
`33`	`33`	`argsman.AddArg("create", "Create new wallet file", ArgsManager::ALLOW_ANY, OptionsCategory::COMMANDS);`
`34`		`- argsman.AddArg("salvage", "Attempt to recover private keys from a corrupt wallet", ArgsManager::ALLOW_ANY, OptionsCategory::COMMANDS);`
	`34`	`+ argsman.AddArg("salvage", "Attempt to recover private keys from a corrupt wallet. Warning: 'salvage' is experimental.", ArgsManager::ALLOW_ANY, OptionsCategory::COMMANDS);`
`35`	`35`	`}`
`36`	`36`
`37`	`37`	`static bool WalletAppInit(int argc, char* argv[])`