Skip to content

Commit f4005af

Browse files
committed
Merge bitcoin/bitcoin#24977: rpc: Explain active and internal in listdescriptors
4637bbe rpc: Explain active and internal in listdescriptors (Andrew Chow) Pull request description: The current help text for active and internal in listdescriptors is not particularly helpful. They require the reader to already know what those terms mean. This help text is updated to actually explain the definitions of those words in context of a descriptor wallet. ACKs for top commit: S3RK: ACK 4637bbe jarolrod: ACK 4637bbe w0xlt: ACK bitcoin/bitcoin@4637bbe Tree-SHA512: 0af2c04f3b9920799cf616ad618bde9248eb9f74cc28f443b5b0f6646deba76e9b1415aca0865ad3bcc24aa6af0e9d07ad7b7cd80f0fe80838cf847f1b944426
2 parents cc3877f + 4637bbe commit f4005af

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

src/wallet/rpc/backup.cpp

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1745,13 +1745,13 @@ RPCHelpMan listdescriptors()
17451745
{RPCResult::Type::OBJ, "", "", {
17461746
{RPCResult::Type::STR, "desc", "Descriptor string representation"},
17471747
{RPCResult::Type::NUM, "timestamp", "The creation time of the descriptor"},
1748-
{RPCResult::Type::BOOL, "active", "Activeness flag"},
1749-
{RPCResult::Type::BOOL, "internal", true, "Whether this is an internal or external descriptor; defined only for active descriptors"},
1750-
{RPCResult::Type::ARR_FIXED, "range", true, "Defined only for ranged descriptors", {
1748+
{RPCResult::Type::BOOL, "active", "Whether this descriptor is currently used to generate new addresses"},
1749+
{RPCResult::Type::BOOL, "internal", /*optional=*/true, "True if this descriptor is used to generate change addresses. False if this descriptor is used to generate receiving addresses; defined only for active descriptors"},
1750+
{RPCResult::Type::ARR_FIXED, "range", /*optional=*/true, "Defined only for ranged descriptors", {
17511751
{RPCResult::Type::NUM, "", "Range start inclusive"},
17521752
{RPCResult::Type::NUM, "", "Range end inclusive"},
17531753
}},
1754-
{RPCResult::Type::NUM, "next", true, "The next index to generate addresses from; defined only for ranged descriptors"},
1754+
{RPCResult::Type::NUM, "next", /*optional=*/true, "The next index to generate addresses from; defined only for ranged descriptors"},
17551755
}},
17561756
}}
17571757
}},

0 commit comments

Comments
 (0)