test: Fix intermittent failure in ChainStateManager tests

mzumsande · mzumsande · commit f8abcb3e3b2e · 2023-03-27T15:47:32.000-04:00
Before wiping the ChainStateManager, the validationinterface
queue must be drained to avoid accessing deleted memory.
diff --git a/src/test/validation_chainstatemanager_tests.cpp b/src/test/validation_chainstatemanager_tests.cpp
@@ -367,10 +367,13 @@ struct SnapshotTestSetup : TestChain100Setup {
 
         BOOST_TEST_MESSAGE("Simulating node restart");
         {
-            LOCK(::cs_main);
             for (Chainstate* cs : chainman.GetAll()) {
+                LOCK(::cs_main);
                 cs->ForceFlushStateToDisk();
             }
+            // Process all callbacks referring to the old manager before wiping it.
+            SyncWithValidationInterfaceQueue();
+            LOCK(::cs_main);
             chainman.ResetChainstates();
             BOOST_CHECK_EQUAL(chainman.GetAll().size(), 0);
             const ChainstateManager::Options chainman_opts{

Original file line number	Diff line number	Diff line change
`@@ -367,10 +367,13 @@ struct SnapshotTestSetup : TestChain100Setup {`
`367`	`367`
`368`	`368`	`BOOST_TEST_MESSAGE("Simulating node restart");`
`369`	`369`	`{`
`370`		`- LOCK(::cs_main);`
`371`	`370`	`for (Chainstate* cs : chainman.GetAll()) {`
	`371`	`+ LOCK(::cs_main);`
`372`	`372`	`cs->ForceFlushStateToDisk();`
`373`	`373`	`}`
	`374`	`+ // Process all callbacks referring to the old manager before wiping it.`
	`375`	`+ SyncWithValidationInterfaceQueue();`
	`376`	`+ LOCK(::cs_main);`
`374`	`377`	`chainman.ResetChainstates();`
`375`	`378`	`BOOST_CHECK_EQUAL(chainman.GetAll().size(), 0);`
`376`	`379`	`const ChainstateManager::Options chainman_opts{`