File tree Expand file tree Collapse file tree 3 files changed +2
-5
lines changed Expand file tree Collapse file tree 3 files changed +2
-5
lines changed Original file line number Diff line number Diff line change @@ -5399,7 +5399,7 @@ void ChainstateManager::CheckBlockIndex()
5399
5399
// and the transactions were not pruned (pindexFirstMissing
5400
5400
// is null), it is a potential candidate. The check
5401
5401
// excludes pruned blocks, because if any blocks were
5402
- // pruned between pindex the current chain tip, pindex will
5402
+ // pruned between pindex and the current chain tip, pindex will
5403
5403
// only temporarily be added to setBlockIndexCandidates,
5404
5404
// before being moved to m_blocks_unlinked. This check
5405
5405
// could be improved to verify that if all blocks between
Original file line number Diff line number Diff line change @@ -1094,8 +1094,7 @@ class ChainstateManager
1094
1094
// ! - Verify that the hash of the resulting coinsdb matches the expected hash
1095
1095
// ! per assumeutxo chain parameters.
1096
1096
// ! - Wait for our headers chain to include the base block of the snapshot.
1097
- // ! - "Fast forward" the tip of the new chainstate to the base of the snapshot,
1098
- // ! faking nTx* block index data along the way.
1097
+ // ! - "Fast forward" the tip of the new chainstate to the base of the snapshot.
1099
1098
// ! - Move the new chainstate to `m_snapshot_chainstate` and make it our
1100
1099
// ! ChainstateActive().
1101
1100
[[nodiscard]] util::Result<CBlockIndex*> ActivateSnapshot (
Original file line number Diff line number Diff line change @@ -96,8 +96,6 @@ def expected_error(msg):
96
96
self .log .info (" - snapshot file referring to a block that is not in the assumeutxo parameters" )
97
97
prev_block_hash = self .nodes [0 ].getblockhash (SNAPSHOT_BASE_HEIGHT - 1 )
98
98
bogus_block_hash = "0" * 64 # Represents any unknown block hash
99
- # The height is not used for anything critical currently, so we just
100
- # confirm the manipulation in the error message
101
99
for bad_block_hash in [bogus_block_hash , prev_block_hash ]:
102
100
with open (bad_snapshot_path , 'wb' ) as f :
103
101
f .write (valid_snapshot_contents [:11 ] + bytes .fromhex (bad_block_hash )[::- 1 ] + valid_snapshot_contents [43 :])
You can’t perform that action at this time.
0 commit comments