Reject + sign when checking -ipcfd

MarcoFalke · MarcoFalke · commit fa123afa0ef7 · 2025-05-15T22:12:15.000+02:00
diff --git a/src/ipc/process.cpp b/src/ipc/process.cpp
@@ -55,9 +55,11 @@ class ProcessImpl : public Process
         // in combination with other arguments because the parent process
         // should be able to control the child process through the IPC protocol
         // without passing information out of band.
-        if (!ParseInt32(argv[2], &fd)) {
+        const auto maybe_fd{ToIntegral<int32_t>(argv[2])};
+        if (!maybe_fd) {
             throw std::runtime_error(strprintf("Invalid -ipcfd number '%s'", argv[2]));
         }
+        fd = *maybe_fd;
         return true;
     }
     int connect(const fs::path& data_dir,

Original file line number	Diff line number	Diff line change
`@@ -55,9 +55,11 @@ class ProcessImpl : public Process`
`55`	`55`	`// in combination with other arguments because the parent process`
`56`	`56`	`// should be able to control the child process through the IPC protocol`
`57`	`57`	`// without passing information out of band.`
`58`		`- if (!ParseInt32(argv[2], &fd)) {`
	`58`	`+ const auto maybe_fd{ToIntegral<int32_t>(argv[2])};`
	`59`	`+ if (!maybe_fd) {`
`59`	`60`	`throw std::runtime_error(strprintf("Invalid -ipcfd number '%s'", argv[2]));`
`60`	`61`	`}`
	`62`	`+ fd = *maybe_fd;`
`61`	`63`	`return true;`
`62`	`64`	`}`
`63`	`65`	`int connect(const fs::path& data_dir,`