Skip to content

Commit fa15a99

Browse files
author
MarcoFalke
committed
test: Remove unused sanitizer suppressions
* The GCC suppression was fixed in gcc-11, which is available on all LTS releases of Linux distros. * The feerate suppression was likely fixed and does not trigger anymore. If it was to trigger again, the underlying bug should be fixed instead of suppressing it. * The bench suppression does not trigger anymore. Also, add comments to tsan suppressions on how to reproduce.
1 parent 4c40837 commit fa15a99

File tree

2 files changed

+3
-7
lines changed

2 files changed

+3
-7
lines changed

test/sanitizer_suppressions/tsan

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,8 @@ race:zmq::*
1313
race:bitcoin-qt
1414

1515
# deadlock (TODO fix)
16+
# To reproduce, see:
17+
# https://github.com/bitcoin/bitcoin/issues/19303#issuecomment-1514926359
1618
deadlock:Chainstate::ConnectTip
1719

1820
# Intentional deadlock in tests
@@ -35,7 +37,7 @@ race:libzmq
3537
# https://github.com/bitcoin/bitcoin/issues/20618
3638
race:CZMQAbstractPublishNotifier::SendZmqMessage
3739

38-
# https://github.com/bitcoin/bitcoin/pull/20218, https://github.com/bitcoin/bitcoin/pull/20745
40+
# https://github.com/bitcoin/bitcoin/pull/27498#issuecomment-1517410478
3941
race:epoll_ctl
4042

4143
# https://github.com/bitcoin/bitcoin/issues/23366

test/sanitizer_suppressions/ubsan

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -5,16 +5,12 @@
55
# names can be used.
66
# See https://github.com/google/sanitizers/issues/1364
77

8-
# https://github.com/bitcoin/bitcoin/pull/21798#issuecomment-829180719
9-
signed-integer-overflow:policy/feerate.cpp
10-
118
# -fsanitize=integer suppressions
129
# ===============================
1310
# Dependencies
1411
# ------------
1512
# Suppressions in dependencies that are developed outside this repository.
1613
unsigned-integer-overflow:*/include/c++/
17-
unsigned-integer-overflow:bench/bench.h
1814
# unsigned-integer-overflow in FuzzedDataProvider's ConsumeIntegralInRange
1915
unsigned-integer-overflow:FuzzedDataProvider.h
2016
unsigned-integer-overflow:leveldb/
@@ -31,8 +27,6 @@ implicit-signed-integer-truncation:leveldb/
3127
implicit-unsigned-integer-truncation:*/include/c++/
3228
implicit-unsigned-integer-truncation:leveldb/
3329
implicit-unsigned-integer-truncation:test/fuzz/crypto_diff_fuzz_chacha20.cpp
34-
# std::variant warning fixed in https://github.com/gcc-mirror/gcc/commit/074436cf8cdd2a9ce75cadd36deb8301f00e55b9
35-
implicit-unsigned-integer-truncation:std::__detail::__variant::_Variant_storage
3630
shift-base:*/include/c++/
3731
shift-base:leveldb/
3832
shift-base:minisketch/

0 commit comments

Comments
 (0)