Pass fImporting to ImportingNow helper class

Author: MarcoFalke

src/node/blockstorage.cpp

@@ -844,17 +844,20 @@ FlatFilePos BlockManager::SaveBlockToDisk(const CBlock& block, int nHeight, CCha
     return blockPos;
 }
 
-struct CImportingNow {
-    CImportingNow()
+class ImportingNow
+{
+    std::atomic<bool>& m_importing;
+
+public:
+    ImportingNow(std::atomic<bool>& importing) : m_importing{importing}
     {
-        assert(fImporting == false);
-        fImporting = true;
+        assert(m_importing == false);
+        m_importing = true;
     }
-
-    ~CImportingNow()
+    ~ImportingNow()
     {
-        assert(fImporting == true);
-        fImporting = false;
+        assert(m_importing == true);
+        m_importing = false;
     }
 };
 
@@ -864,7 +867,7 @@ void ThreadImport(ChainstateManager& chainman, std::vector<fs::path> vImportFile
     ScheduleBatchPriority();
 
     {
-        CImportingNow imp;
+        ImportingNow imp{fImporting};
 
         // -reindex
         if (fReindex) {
@@ -930,7 +933,7 @@ void ThreadImport(ChainstateManager& chainman, std::vector<fs::path> vImportFile
             StartShutdown();
             return;
         }
-    } // End scope of CImportingNow
+    } // End scope of ImportingNow
     chainman.ActiveChainstate().LoadMempool(mempool_path);
 }
 } // namespace node