Skip to content

Commit fa68dcb

Browse files
author
MarcoFalke
committed
ci: Add missing errexit to lint CI install
Otherwise, a possible failure is silently ignored. Also, rename the file, while touching it, to clarify installing is the first step.
1 parent fa535a6 commit fa68dcb

File tree

4 files changed

+5
-3
lines changed

4 files changed

+5
-3
lines changed

ci/lint/04_install.sh renamed to ci/lint/01_install.sh

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,8 @@
66

77
export LC_ALL=C
88

9+
set -o errexit -o pipefail -o xtrace
10+
911
export CI_RETRY_EXE="/ci_retry --"
1012

1113
pushd "/"

ci/lint_imagefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ ENV LC_ALL=C.UTF-8
1212
COPY ./ci/retry/retry /ci_retry
1313
COPY ./.python-version /.python-version
1414
COPY ./ci/lint/container-entrypoint.sh /entrypoint.sh
15-
COPY ./ci/lint/04_install.sh /install.sh
15+
COPY ./ci/lint/01_install.sh /install.sh
1616

1717
RUN /install.sh && \
1818
echo 'alias lint="./ci/lint/06_script.sh"' >> ~/.bashrc && \

ci/lint_run_all.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,6 @@ cp "./ci/retry/retry" "/ci_retry"
1313
cp "./.python-version" "/.python-version"
1414
mkdir --parents "/test/lint"
1515
cp --recursive "./test/lint/test_runner" "/test/lint/"
16-
set -o errexit; source ./ci/lint/04_install.sh
16+
set -o errexit; source ./ci/lint/01_install.sh
1717
set -o errexit
1818
./ci/lint/06_script.sh

test/lint/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ or `--help`:
5454
| `py_lint` | [ruff](https://github.com/astral-sh/ruff)
5555
| markdown link check | [mlc](https://github.com/becheran/mlc)
5656

57-
In use versions and install instructions are available in the [CI setup](../../ci/lint/04_install.sh).
57+
In use versions and install instructions are available in the [CI setup](../../ci/lint/01_install.sh).
5858

5959
Please be aware that on Linux distributions all dependencies are usually available as packages, but could be outdated.
6060

0 commit comments

Comments
 (0)