Skip to content

Commit fa79af2

Browse files
author
MarcoFalke
committed
test: Replace fragile "rng" with call to random()
1 parent fac3dcf commit fa79af2

File tree

1 file changed

+11
-2
lines changed

1 file changed

+11
-2
lines changed

test/functional/wallet_import_rescan.py

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,10 @@
2727
)
2828

2929
import collections
30+
from decimal import Decimal
3031
import enum
3132
import itertools
33+
import random
3234

3335
Call = enum.Enum("Call", "single multiaddress multiscript")
3436
Data = enum.Enum("Data", "address pub priv")
@@ -117,6 +119,13 @@ def check(self, txid=None, amount=None, confirmation_height=None):
117119
# Rescans start at the earliest block up to 2 hours before the key timestamp.
118120
TIMESTAMP_WINDOW = 2 * 60 * 60
119121

122+
AMOUNT_DUST = 0.00000546
123+
124+
125+
def get_rand_amount():
126+
r = random.uniform(AMOUNT_DUST, 1)
127+
return Decimal(str(round(r, 8)))
128+
120129

121130
class ImportRescanTest(BitcoinTestFramework):
122131
def set_test_params(self):
@@ -150,7 +159,7 @@ def run_test(self):
150159
variant.label = "label {} {}".format(i, variant)
151160
variant.address = self.nodes[1].getaddressinfo(self.nodes[1].getnewaddress(variant.label))
152161
variant.key = self.nodes[1].dumpprivkey(variant.address["address"])
153-
variant.initial_amount = 1 - (i + 1) / 64
162+
variant.initial_amount = get_rand_amount()
154163
variant.initial_txid = self.nodes[0].sendtoaddress(variant.address["address"], variant.initial_amount)
155164
self.nodes[0].generate(1) # Generate one block for each send
156165
variant.confirmation_height = self.nodes[0].getblockcount()
@@ -183,7 +192,7 @@ def run_test(self):
183192

184193
# Create new transactions sending to each address.
185194
for i, variant in enumerate(IMPORT_VARIANTS):
186-
variant.sent_amount = 1 - (2 * i + 1) / 128
195+
variant.sent_amount = get_rand_amount()
187196
variant.sent_txid = self.nodes[0].sendtoaddress(variant.address["address"], variant.sent_amount)
188197
self.nodes[0].generate(1) # Generate one block for each send
189198
variant.confirmation_height = self.nodes[0].getblockcount()

0 commit comments

Comments
 (0)