Skip to content

Commit faa7144

Browse files
author
MarcoFalke
committed
fuzz: re-enable prioritisetransaction & analyzepsbt RPC
1 parent 19764dc commit faa7144

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

src/test/fuzz/rpc.cpp

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,6 @@ const std::vector<std::string> RPC_COMMANDS_NOT_SAFE_FOR_FUZZING{
7070
"addconnection", // avoid DNS lookups
7171
"addnode", // avoid DNS lookups
7272
"addpeeraddress", // avoid DNS lookups
73-
"analyzepsbt", // avoid signed integer overflow in CFeeRate::GetFee(unsigned long) (https://github.com/bitcoin/bitcoin/issues/20607)
7473
"dumptxoutset", // avoid writing to disk
7574
"dumpwallet", // avoid writing to disk
7675
"echoipc", // avoid assertion failure (Assertion `"EnsureAnyNodeContext(request.context).init" && check' failed.)
@@ -79,14 +78,14 @@ const std::vector<std::string> RPC_COMMANDS_NOT_SAFE_FOR_FUZZING{
7978
"gettxoutproof", // avoid prohibitively slow execution
8079
"importwallet", // avoid reading from disk
8180
"loadwallet", // avoid reading from disk
82-
"prioritisetransaction", // avoid signed integer overflow in CTxMemPool::PrioritiseTransaction(uint256 const&, long const&) (https://github.com/bitcoin/bitcoin/issues/20626)
8381
"savemempool", // disabled as a precautionary measure: may take a file path argument in the future
8482
"setban", // avoid DNS lookups
8583
"stop", // avoid shutdown state
8684
};
8785

8886
// RPC commands which are safe for fuzzing.
8987
const std::vector<std::string> RPC_COMMANDS_SAFE_FOR_FUZZING{
88+
"analyzepsbt",
9089
"clearbanned",
9190
"combinepsbt",
9291
"combinerawtransaction",
@@ -112,9 +111,9 @@ const std::vector<std::string> RPC_COMMANDS_SAFE_FOR_FUZZING{
112111
"getblockchaininfo",
113112
"getblockcount",
114113
"getblockfilter",
114+
"getblockfrompeer", // when no peers are connected, no p2p message is sent
115115
"getblockhash",
116116
"getblockheader",
117-
"getblockfrompeer", // when no peers are connected, no p2p message is sent
118117
"getblockstats",
119118
"getblocktemplate",
120119
"getchaintips",
@@ -128,7 +127,6 @@ const std::vector<std::string> RPC_COMMANDS_SAFE_FOR_FUZZING{
128127
"getmempoolancestors",
129128
"getmempooldescendants",
130129
"getmempoolentry",
131-
"gettxspendingprevout",
132130
"getmempoolinfo",
133131
"getmininginfo",
134132
"getnettotals",
@@ -141,6 +139,7 @@ const std::vector<std::string> RPC_COMMANDS_SAFE_FOR_FUZZING{
141139
"getrpcinfo",
142140
"gettxout",
143141
"gettxoutsetinfo",
142+
"gettxspendingprevout",
144143
"help",
145144
"invalidateblock",
146145
"joinpsbts",
@@ -149,6 +148,7 @@ const std::vector<std::string> RPC_COMMANDS_SAFE_FOR_FUZZING{
149148
"mockscheduler",
150149
"ping",
151150
"preciousblock",
151+
"prioritisetransaction",
152152
"pruneblockchain",
153153
"reconsiderblock",
154154
"scanblocks",

0 commit comments

Comments
 (0)