Skip to content

Commit faa94cb

Browse files
author
MarcoFalke
committed
test: Check that invalid peer traffic is accounted for
1 parent fae243f commit faa94cb

File tree

1 file changed

+6
-3
lines changed

1 file changed

+6
-3
lines changed

test/functional/p2p_invalid_messages.py

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,12 +22,11 @@
2222
P2PInterface,
2323
)
2424
from test_framework.test_framework import BitcoinTestFramework
25-
from test_framework.util import (
26-
assert_equal,
27-
)
25+
from test_framework.util import assert_equal
2826

2927
VALID_DATA_LIMIT = MAX_PROTOCOL_MESSAGE_LENGTH - 5 # Account for the 5-byte length prefix
3028

29+
3130
class msg_unrecognized:
3231
"""Nonsensical message. Modeled after similar types in test_framework.messages."""
3332

@@ -100,6 +99,8 @@ def test_checksum(self):
10099
msg = msg[:cut_len] + b'\xff' * 4 + msg[cut_len + 4:]
101100
conn.send_raw_message(msg)
102101
conn.sync_with_ping(timeout=1)
102+
# Check that traffic is accounted for (24 bytes header + 2 bytes payload)
103+
assert_equal(self.nodes[0].getpeerinfo()[0]['bytesrecv_per_msg']['*other*'], 26)
103104
self.nodes[0].disconnect_p2ps()
104105

105106
def test_size(self):
@@ -123,6 +124,8 @@ def test_msgtype(self):
123124
msg = msg[:7] + b'\x00' + msg[7 + 1:]
124125
conn.send_raw_message(msg)
125126
conn.sync_with_ping(timeout=1)
127+
# Check that traffic is accounted for (24 bytes header + 2 bytes payload)
128+
assert_equal(self.nodes[0].getpeerinfo()[0]['bytesrecv_per_msg']['*other*'], 26)
126129
self.nodes[0].disconnect_p2ps()
127130

128131
def test_oversized_msg(self, msg, size):

0 commit comments

Comments
 (0)