Skip to content

Commit faac7a2

Browse files
author
MarcoFalke
committed
qa: Avoid checking reject code for now
The node will often disconnect before sending a reject code. A more robust solution would be to read from the debug log.
1 parent 472fe8a commit faac7a2

File tree

1 file changed

+1
-3
lines changed

1 file changed

+1
-3
lines changed

test/functional/p2p_invalid_tx.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,6 @@
2121
)
2222

2323

24-
REJECT_INVALID = 16
25-
2624
class InvalidTxRequestTest(BitcoinTestFramework):
2725
def set_test_params(self):
2826
self.num_nodes = 1
@@ -73,7 +71,7 @@ def run_test(self):
7371
# and we get disconnected immediately
7472
self.log.info('Test a transaction that is rejected')
7573
tx1 = create_transaction(block1.vtx[0], 0, b'\x64' * 35, 50 * COIN - 12000)
76-
node.p2p.send_txs_and_test([tx1], node, success=False, expect_disconnect=True, reject_code=REJECT_INVALID, reject_reason=b'mandatory-script-verify-flag-failed (Invalid OP_IF construction)')
74+
node.p2p.send_txs_and_test([tx1], node, success=False, expect_disconnect=True)
7775

7876
# Make two p2p connections to provide the node with orphans
7977
# * p2ps[0] will send valid orphan txs (one with low fee)

0 commit comments

Comments
 (0)