refactor: performance-for-range-copy in psbt.h

MarcoFalke · MarcoFalke · commit fab01b5220c2 · 2024-06-09T13:07:35.000+02:00
diff --git a/src/psbt.h b/src/psbt.h
@@ -237,7 +237,7 @@ struct PSBTInput
 
         if (final_script_sig.empty() && final_script_witness.IsNull()) {
             // Write any partial signatures
-            for (auto sig_pair : partial_sigs) {
+            for (const auto& sig_pair : partial_sigs) {
                 SerializeToVector(s, CompactSizeWriter(PSBT_IN_PARTIAL_SIG), Span{sig_pair.second.first});
                 s << sig_pair.second.second;
             }

Original file line number	Diff line number	Diff line change
`@@ -237,7 +237,7 @@ struct PSBTInput`
`237`	`237`
`238`	`238`	`if (final_script_sig.empty() && final_script_witness.IsNull()) {`
`239`	`239`	`// Write any partial signatures`
`240`		`- for (auto sig_pair : partial_sigs) {`
	`240`	`+ for (const auto& sig_pair : partial_sigs) {`
`241`	`241`	`SerializeToVector(s, CompactSizeWriter(PSBT_IN_PARTIAL_SIG), Span{sig_pair.second.first});`
`242`	`242`	`s << sig_pair.second.second;`
`243`	`243`	`}`