Skip to content

Commit fab79c1

Browse files
author
MarcoFalke
committed
doc: Clarify and move "hygienic commit" note
The prior version mentions to update the tests *first*, which is wrong. It must be updated at the same time in the same commit.
1 parent fac8b05 commit fab79c1

File tree

2 files changed

+1
-3
lines changed

2 files changed

+1
-3
lines changed

CONTRIBUTING.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -115,6 +115,7 @@ fixes or code moves with actual code changes.
115115

116116
Make sure each individual commit is hygienic: that it builds successfully on its
117117
own without warnings, errors, regressions, or test failures.
118+
This means tests must be updated in the same commit that changes the behavior.
118119

119120
Commit messages should be verbose by default consisting of a short subject line
120121
(50 chars max), a blank line and detailed explanatory text as separate

doc/developer-notes.md

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -805,9 +805,6 @@ General Bitcoin Core
805805
on the master branch. Otherwise, all new pull requests will start failing the tests, resulting in
806806
confusion and mayhem.
807807

808-
- *Explanation*: If the test suite is to be updated for a change, this has to
809-
be done first.
810-
811808
Logging
812809
-------
813810

0 commit comments

Comments
 (0)